-
Notifications
You must be signed in to change notification settings - Fork 3
feat: add Bento style to MCP page #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Lasserich
commented
Sep 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a Bento-style grid layout to the MCP page, replacing the previous hints cards row and component sections with an interactive dashboard design. The changes implement a flexible grid system that allows for component expansion and provides better visual organization of control plane information.
- Introduces BentoGrid layout with responsive card system supporting different sizes (small, medium, large, extra-large)
- Replaces HintsCardsRow component with new ComponentCard-based BentoGrid design
- Adds member management functionality with new members component card
Reviewed Changes
Copilot reviewed 33 out of 39 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/spaces/mcp/pages/McpPage.tsx | Completely refactors the page to use BentoGrid layout with expandable ComponentCards |
| src/components/BentoGrid/ | New component system with grid layout, cards, and multi-percentage bars |
| src/utils/componentCardCalculations.ts | Updates calculation functions to work with new card system and adds members calculation |
| src/components/HintsCardsRow/ | Removes old hints cards row components |
| src/types/types.ts | Makes types generic to support different data types beyond ManagedResourceItem |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| calculateCrossplaneHoverData, | ||
| HINT_COLORS, | ||
| } from './hintsCardsRowCalculations'; | ||
| } from './componentCardCalculations'; |
Copilot
AI
Sep 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File import path has a typo. Should be './componentCardCalculations' (missing 's' in 'Cards').
| } from './componentCardCalculations'; | |
| } from './componentCardsCalculations'; |
Copilot uses AI. Check for mistakes.
| AnimationConfig, | ||
| LabelPosition, | ||
| LabelDisplayMode, | ||
| }; |
Copilot
AI
Sep 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Consider exporting these interfaces from a separate types file to improve maintainability and reduce the size of this component file.
Copilot uses AI. Check for mistakes.
public/locales/en.json
Outdated
| "GitOpsHint": { | ||
| "title": "Flux", | ||
| "subtitle": "GitOps Progress", | ||
| "subtitle": "Persist desired state in code repsitories", |
Copilot
AI
Sep 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a typo in 'repsitories'. Should be 'repositories'.
| "subtitle": "Persist desired state in code repsitories", | |
| "subtitle": "Persist desired state in code repositories", |
Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <[email protected]>
|
This is rough, co-pilot only having 3 comments on 6k lines of code? 😭 😂 |